Skip to content

PROD-2439 Save Draft -> PROD-2321 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

mmattlin
Copy link

What's in this PR?

  • Modified logic so that user can Save For Later even if form is not valid. To do this I added the concept of form actions: "save" meaning that it bypasses validity check when saving the form, and "submit" meaning that form must be valid to save successfully (default is submit). This is now an optional prop for Form, so a button click could change the value of the prop and the form would save accordingly. This seems a bit hacky to me, but I couldn't figure out any other way to determine which button had been clicked (Save for Later vs. Review & Pay) within Form onSubmitAsync.
  • Added functionality for the "back" button at the bottom left to navigate back to the previous page without saving
  • Updated styling for disabled buttons so that it doesn't show a pointer cursor or green border on focus

@mmattlin mmattlin merged commit bf59292 into PROD-2321_bug-hunt-intake-form Jul 22, 2022
@mmattlin mmattlin deleted the PROD-2439_save-draft branch July 22, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants